Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove performance-test workflow and relative makefile entry #2706

Merged
merged 3 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/CI.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,6 @@ jobs:
runtime_tag: dev-${{ needs.prepare_ci_run.outputs.DATETIME }}
uses: ./.github/workflows/e2e-test.yml

performance_tests:
name: Performance Tests
needs: [prepare_ci_run, build_image]
with:
runtime_tag: dev-${{ needs.prepare_ci_run.outputs.DATETIME }}
uses: ./.github/workflows/performance-test.yml

helm_charts_publish:
name: Publish helm chart changes to charts repo
if: github.event_name == 'push' && needs.prepare_ci_run.outputs.NON_FORKED_AND_NON_ROBOT_RUN == 'true'
Expand Down
43 changes: 0 additions & 43 deletions .github/workflows/performance-test.yml

This file was deleted.

6 changes: 1 addition & 5 deletions lifecycle-operator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,13 @@ component-test: manifests generate envtest ## Run tests.
cat cover-app.out cover-appversion.out cover-evaluation.out cover-task.out cover-taskdefinition.out cover-workload.out cover-workloadversion.out >> cover.out
rm cover-app.out cover-appversion.out cover-evaluation.out cover-task.out cover-taskdefinition.out cover-workload.out cover-workloadversion.out

.PHONY: performance-test
performance-test: manifests generate envtest ## Run tests.
go test ./test/component/... -v -timeout 30m --ginkgo.focus="Feature:Performance"

.PHONY: e2e-test
e2e-test: manifests generate envtest ## Run tests.
go test ./test/e2e -v -coverprofile cover.out --ginkgo.focus="E2E"

#command(make test) to run all tests
.PHONY: test
test: unit-test component-test performance-test e2e-test
test: unit-test component-test e2e-test

##@ Build
.PHONY: build
Expand Down
8 changes: 0 additions & 8 deletions lifecycle-operator/test/component/DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@ var _ = Describe("KeptnAppController", func() {

<!-- markdownlint-enable MD010 -->

## Load Tests

You can append ```[Feature:Performance]``` to any spec you would like to execute during performance test
with ```make performance-test``` the file
"load_test.go" contains examples of such tests, including a simple reporter.
The report "MetricForLoadTestSuite" is
generated for every run of the load test.

## Contributing Tips

1. Keep in mind to clean up after each test since the environment is shared.
Expand Down
8 changes: 0 additions & 8 deletions lifecycle-operator/test/e2e/DEVELOPER.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@ If annotated for keptn, a new Pod should be assigned to keptn scheduler | passed

## Contributing

## Load Tests

You can append ```[Feature:Performance]``` to any spec you would like to execute during performance test
with ```make performance-test``` the file
"load_test.go" contains examples of such tests, including a simple reporter.
The report "MetricForLoadTestSuite" is
generated for every run of the load test.

## Contributing Tips

1. Keep in mind to clean up after each test since the environment is shared.
Expand Down
Loading