-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adapt helm charts to the new Keptn naming #2564
Conversation
Signed-off-by: odubajDT <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
==========================================
+ Coverage 85.48% 85.51% +0.02%
==========================================
Files 155 155
Lines 10177 10177
==========================================
+ Hits 8700 8703 +3
+ Misses 1198 1196 -2
+ Partials 279 278 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we care about the scheduler? I see there is a klt constant in there...
Sure, where do you see it? I cannot find any |
Ignore me, I was checking the wrong branch this was edited before :) |
@@ -2,7 +2,7 @@ domain: keptn.sh | |||
layout: | |||
- go.kubebuilder.io/v3 | |||
multigroup: true | |||
projectName: keptn-lifecycle-toolkit | |||
projectName: keptn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should actually be keptn-lifecycle-operator no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be fixed as part of #2565
@@ -6,7 +6,7 @@ metadata: | |||
cert-manager.io/inject-ca-from: '{{ .Release.Namespace }}/keptn-certs' | |||
labels: | |||
keptn.sh/inject-cert: "true" | |||
app.kubernetes.io/part-of: "keptn-lifecycle-toolkit" | |||
app.kubernetes.io/part-of: "keptn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't use quotes anywhere else, i think we could remove them here as well :)
app.kubernetes.io/part-of: "keptn" | |
app.kubernetes.io/part-of: keptn |
Part-of #2079
Changes
part-of
label fromkeptn-lifecycle-toolkit
tokeptn
created-by
label fromkeptn-lifecycle-toolkit
tokeptn
klt-cert-manager
tokeptn-cert-manager
go.mod
filesFollow-up
keptn-lifecycle-toolkit-system
tokeptn-system