Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt helm charts to the new Keptn naming #2564

Merged
merged 2 commits into from
Nov 27, 2023
Merged

chore: adapt helm charts to the new Keptn naming #2564

merged 2 commits into from
Nov 27, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 24, 2023

Part-of #2079

Changes

  • renamed part-of label from keptn-lifecycle-toolkit to keptn
  • renamed created-by label from keptn-lifecycle-toolkit to keptn
  • updated helm tests
  • adapted links and imports from klt-cert-manager to keptn-cert-manager
  • updated go.mod files
  • cleanup leftover KLT ocurrences

Follow-up

  • rename Keptn default namespace from keptn-lifecycle-toolkit-system to keptn-system

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit bb75755
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/656054e7ea6e080008534045
😎 Deploy Preview https://deploy-preview-2564--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #2564 (4a2d826) into main (15b0ac0) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
+ Coverage   85.48%   85.51%   +0.02%     
==========================================
  Files         155      155              
  Lines       10177    10177              
==========================================
+ Hits         8700     8703       +3     
+ Misses       1198     1196       -2     
+ Partials      279      278       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 57.09% <ø> (+0.76%) ⬆️
lifecycle-operator 84.44% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@odubajDT odubajDT marked this pull request as ready for review November 24, 2023 08:07
@odubajDT odubajDT requested review from a team as code owners November 24, 2023 08:07
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we care about the scheduler? I see there is a klt constant in there...

@odubajDT
Copy link
Contributor Author

do we care about the scheduler? I see there is a klt constant in there...

Sure, where do you see it? I cannot find any

@RealAnna
Copy link
Contributor

do we care about the scheduler? I see there is a klt constant in there...

Sure, where do you see it? I cannot find any

Ignore me, I was checking the wrong branch this was edited before :)

@odubajDT odubajDT merged commit 9ee4583 into keptn:main Nov 27, 2023
50 checks passed
@@ -2,7 +2,7 @@ domain: keptn.sh
layout:
- go.kubebuilder.io/v3
multigroup: true
projectName: keptn-lifecycle-toolkit
projectName: keptn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should actually be keptn-lifecycle-operator no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed as part of #2565

@@ -6,7 +6,7 @@ metadata:
cert-manager.io/inject-ca-from: '{{ .Release.Namespace }}/keptn-certs'
labels:
keptn.sh/inject-cert: "true"
app.kubernetes.io/part-of: "keptn-lifecycle-toolkit"
app.kubernetes.io/part-of: "keptn"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use quotes anywhere else, i think we could remove them here as well :)

Suggested change
app.kubernetes.io/part-of: "keptn"
app.kubernetes.io/part-of: keptn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants