Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: introduce e2e test for keptn.sh/container annotation #2499

Merged
merged 3 commits into from
Nov 15, 2023
Merged

test: introduce e2e test for keptn.sh/container annotation #2499

merged 3 commits into from
Nov 15, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 14, 2023

Fixes #2464

Depends on #2471

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit eec7355
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6553735842101700085a550f
😎 Deploy Preview https://deploy-preview-2499--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2499 (72f4874) into main (d093860) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2499      +/-   ##
==========================================
- Coverage   85.64%   85.63%   -0.02%     
==========================================
  Files         170      170              
  Lines       10528    10523       -5     
==========================================
- Hits         9017     9011       -6     
- Misses       1231     1232       +1     
  Partials      280      280              
Files Coverage Δ
...erator/webhooks/pod_mutator/handlers/objectmeta.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.73% <ø> (+0.49%) ⬆️
lifecycle-operator 84.42% <ø> (-0.02%) ⬇️
metrics-operator 87.75% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review November 15, 2023 08:01
@odubajDT odubajDT requested a review from a team as a code owner November 15, 2023 08:01
Signed-off-by: odubajDT <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@odubajDT odubajDT merged commit 686bf3c into keptn:main Nov 15, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select which container to extract version from in multi-container workloads
3 participants