Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lifecycle-operator): adapt KeptnAppVersionReconciler to make use of PhaseHandler interface #2463

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 9, 2023

Closes #2418

…e of PhaseHandler interface

Signed-off-by: Florian Bacher <[email protected]>
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 80bac59
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/654ccc3c8a4cef0008016344
😎 Deploy Preview https://deploy-preview-2463--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2463 (58c46a6) into main (8bf50a6) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
- Coverage   85.68%   85.57%   -0.12%     
==========================================
  Files         161      161              
  Lines       10202    10196       -6     
==========================================
- Hits         8742     8725      -17     
- Misses       1188     1197       +9     
- Partials      272      274       +2     
Files Coverage Δ
...ontrollers/lifecycle/keptnappversion/controller.go 73.27% <100.00%> (-8.70%) ⬇️

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.24% <40.00%> (+0.51%) ⬆️
lifecycle-operator 84.48% <100.00%> (-0.97%) ⬇️
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review November 9, 2023 14:58
@bacherfl bacherfl requested a review from a team as a code owner November 9, 2023 14:58
@bacherfl bacherfl merged commit 2511e05 into keptn:main Nov 13, 2023
37 checks passed
@bacherfl bacherfl deleted the chore/phasehandler-keptnappversion branch November 13, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants