Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move docs-tooling into repo #2460

Merged
merged 13 commits into from
Nov 13, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Nov 9, 2023

This PR removes the dependency on docs-tooling

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 9, 2023
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 12efba3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6551ecaecf866000080ee18b
😎 Deploy Preview https://deploy-preview-2460--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisthat thisthat marked this pull request as ready for review November 9, 2023 07:31
@thisthat thisthat requested review from a team as code owners November 9, 2023 07:31
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if we really need all those icons and static assets, cus i don't think so.
also, please fix all the spell checker issues, see the spell-check job summary for details

odubajDT
odubajDT previously approved these changes Nov 9, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2460 (be982b9) into main (6085e7e) will decrease coverage by 0.06%.
Report is 16 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
- Coverage   85.74%   85.68%   -0.06%     
==========================================
  Files         161      161              
  Lines       10201    10202       +1     
==========================================
- Hits         8747     8742       -5     
- Misses       1184     1188       +4     
- Partials      270      272       +2     

see 5 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.14% <ø> (-0.54%) ⬇️
lifecycle-operator 85.44% <ø> (-0.81%) ⬇️
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
check-spelling run (pull_request_target) for docs/remove-dep-on-tooling-repo

Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat force-pushed the docs/remove-dep-on-tooling-repo branch from 2ef112f to d10474a Compare November 10, 2023 10:14
.github/actions/spelling/excludes.txt Outdated Show resolved Hide resolved
.github/actions/spelling/expect.txt Outdated Show resolved Hide resolved
.github/actions/spelling/expect.txt Outdated Show resolved Hide resolved
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat marked this pull request as draft November 13, 2023 11:59
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat marked this pull request as ready for review November 13, 2023 12:43
@thisthat thisthat merged commit d69989e into keptn:main Nov 13, 2023
35 checks passed
@thisthat thisthat deleted the docs/remove-dep-on-tooling-repo branch November 13, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants