fix(lifecycle-operator): adopt KeptnApp name from either Keptn or k8s label #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… label Signed-off-by: Florian Bacher <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 161 161
Lines 10200 10201 +1
=======================================
+ Hits 8750 8751 +1
Misses 1181 1181
Partials 269 269
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
approved these changes
Nov 7, 2023
odubajDT
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no app name is set explicitly in the labels/annotations of a pod, the mutating webhook was using the name of the workload for the name of the related, autogenerated app. Afterwards it adds the name of the app as an annotation to the pod, however it did that without considering the
app.kubernetes.io/namelabel, but only based on what is inkeptn.sh/workload. This prevented pods not using thekeptn.sh/workloadlabel from spinning up as the scheduler, which is using these annotations as information for constructing the name of the related workload version, could not find a matching WorkloadVersion.