-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: readability tweaks to "Install" page #2419
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
odubajDT
reviewed
Nov 6, 2023
odubajDT
reviewed
Nov 6, 2023
odubajDT
previously requested changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing html test
odubajDT
reviewed
Nov 6, 2023
odubajDT
reviewed
Nov 6, 2023
odubajDT
reviewed
Nov 6, 2023
bacherfl
reviewed
Nov 6, 2023
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: odubajDT <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
odubajDT
reviewed
Nov 6, 2023
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: odubajDT <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
bacherfl
reviewed
Nov 6, 2023
bacherfl
reviewed
Nov 6, 2023
Signed-off-by: Meg McRoberts <[email protected]>
mowies
requested changes
Nov 6, 2023
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
6 tasks
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
6 tasks
This PR is no longer relevant -- the useful bits were put in other PRs and I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE!
Summary
Improve the readability of the Install page (revised for umbrella charts). We did a quick merge of the basic material, knowing that it needed to be tweaked a bit.
While this PR was written, Mo created an abbreviated document that is much more appropriate. This version is going to be used for some usability testing but should not be merged. Instead, the plan is for me to create a separate "Installation tips and tricks" page that includes the content from this page that is not in the abbreviated installation doc. When that is done, this PR will be closed.
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview