Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add required labels and namespace info for Analysis, AnalysisDefinition, AnalysisValueTemplate #2356

Merged
merged 13 commits into from
Oct 31, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Oct 30, 2023

Closes #2317

This PR:

  • Adds an item about analyses to the "How many namespaces" section
  • Adds info about namespace location to the three yaml-crd-ref reference pages
  • Refined the synopsis and fields definitions for the AnalysisDefinition reference page
  • Link to the yaml-crd-ref pages rather than the API pages from the guide chapter
  • Adds the (required) label as appropriate to the "Field" descriptions

Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Oct 30, 2023
@StackScribe StackScribe added this to the 0.9 milestone Oct 30, 2023
@StackScribe StackScribe self-assigned this Oct 30, 2023
@StackScribe StackScribe requested review from a team as code owners October 30, 2023 09:56
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 6503e82
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65410adda0bca20008f1e878
😎 Deploy Preview https://deploy-preview-2356--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

StackScribe and others added 6 commits October 30, 2023 03:40
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
odubajDT
odubajDT previously approved these changes Oct 31, 2023
Signed-off-by: realanna <[email protected]>
@RealAnna RealAnna force-pushed the 1024-analysis-namespace branch from b796e5c to 4a9f318 Compare October 31, 2023 13:42
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: RealAnna <[email protected]>
odubajDT
odubajDT previously approved these changes Oct 31, 2023
StackScribe and others added 2 commits October 31, 2023 06:57
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: RealAnna <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
odubajDT
odubajDT previously approved these changes Oct 31, 2023
@odubajDT odubajDT changed the title docs: analyses and namespaces docs: add required labels to required CRD fields (Analysis, AnalysisDefinition, AnalysisValueTemplate) Oct 31, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies merged commit 8b6bc79 into keptn:main Oct 31, 2023
15 checks passed
@StackScribe StackScribe changed the title docs: add required labels to required CRD fields (Analysis, AnalysisDefinition, AnalysisValueTemplate) docs: add required labels and namespace info for Analysis, AnalysisDefinition, AnalysisValueTemplate Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add statement about Analysis resources and namespaces
4 participants