Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: enable google custom search engine for production #2335

Merged
merged 2 commits into from
Oct 25, 2023
Merged

docs: enable google custom search engine for production #2335

merged 2 commits into from
Oct 25, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Oct 25, 2023 •
edited
Loading

This PR

  • exchanges the local site search for a google custom search
  • the search only uses pages from the latest release, not the previous versions
  • the custom search is currently owned by @mowies for testing. This needs to be updated in the future to a keptnproject owned engine

Fixes #2319

@mowies mowies requested review from a team as code owners October 25, 2023 12:15
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 9dbb0af
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65390ce075442a000885e2a6
😎 Deploy Preview https://deploy-preview-2335--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mowies mowies changed the title enable google custom search engine for production docs: enable google custom search engine for production Oct 25, 2023
RealAnna
RealAnna previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😄

odubajDT
odubajDT previously approved these changes Oct 25, 2023
View reviewed changes
@mowies
add search page
9dbb0af 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies dismissed stale reviews from odubajDT and RealAnna via 9dbb0af October 25, 2023 12:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit 2ff15a2 into keptn:main Oct 25, 2023
19 checks passed
@mowies mowies deleted the improve-search branch October 25, 2023 13:10
@keptn-bot keptn-bot mentioned this pull request Oct 25, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve docs search by customizing settings and page ranks
3 participants
@mowies @RealAnna @odubajDT