Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run report creation and upload only in case of failure #2325

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

thisthat
Copy link
Member

This PR changes the integration tests to collect and upload logs only in case of failure.
Inspecting the logs for successful runs is not common and these two steps could take as much as running the test itself

image

@thisthat thisthat requested a review from a team as a code owner October 24, 2023 11:12
@github-actions github-actions bot added the ops label Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit e85dd77
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6537a69990553a0009da6c43
😎 Deploy Preview https://deploy-preview-2325--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2325 (76efdd5) into main (adda244) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         161      161           
  Lines       10246    10246           
=======================================
  Hits         8779     8779           
  Misses       1192     1192           
  Partials      275      275           
Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 59.18% <ø> (+0.20%) ⬆️
lifecycle-operator 85.46% <ø> (ø)
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit ec11ffb into keptn:main Oct 24, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants