-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bootstrap webhook/component/integration/performance tests #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealAnna
changed the title
poc: create first example tests
feat: create first example tests (poc)
Oct 25, 2022
RealAnna
force-pushed
the
poc/create_first_tests
branch
2 times, most recently
from
October 28, 2022 09:35
2c650fe
to
c4e7885
Compare
RealAnna
changed the title
feat: create first example tests (poc)
feat: Created first example tests(poc)
Oct 28, 2022
thschue
previously approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
RealAnna
force-pushed
the
poc/create_first_tests
branch
from
November 3, 2022 11:01
f354378
to
48f5aeb
Compare
RealAnna
force-pushed
the
poc/create_first_tests
branch
from
November 3, 2022 11:47
d9b89f7
to
8c8e50f
Compare
philipp-hinteregger
force-pushed
the
poc/create_first_tests
branch
from
November 3, 2022 14:38
d531bf8
to
8c8e50f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=========================================
+ Coverage 5.03% 11.33% +6.29%
=========================================
Files 9 12 +3
Lines 794 1032 +238
=========================================
+ Hits 40 117 +77
- Misses 749 902 +153
- Partials 5 13 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: RealAnna <[email protected]> feat: added example of unit and component test Signed-off-by: RealAnna <[email protected]> feat: fixed imports Signed-off-by: RealAnna <[email protected]> feat: example ginkgo test for app controller Signed-off-by: RealAnna <[email protected]> feat: example ginkgo test for app controller Signed-off-by: RealAnna <[email protected]> feat: example ginkgo test for app controller Signed-off-by: RealAnna <[email protected]> feat: example ginkgo test for app controller Signed-off-by: RealAnna <[email protected]> feat: added example unit test with mock Signed-off-by: RealAnna <[email protected]> feat: fixed bug Signed-off-by: RealAnna <[email protected]> feat: added test Signed-off-by: RealAnna <[email protected]> feat: update test suite with clean E2E test best practice Signed-off-by: RealAnna <[email protected]> feat: update test to avoid vet failure Signed-off-by: RealAnna <[email protected]> feat: init fake Signed-off-by: RealAnna <[email protected]> feat: added fake client for unit test of reconcilers Signed-off-by: RealAnna <[email protected]> feat: fixed appcontroller test Signed-off-by: RealAnna <[email protected]> feat: added a Developer.md file Signed-off-by: RealAnna <[email protected]> feat: fixed for autogen Signed-off-by: RealAnna <[email protected]> feat: clean up test add traces Signed-off-by: RealAnna <[email protected]> feat: added more tips Signed-off-by: RealAnna <[email protected]> feat: added stuff from k8s developer guide Signed-off-by: RealAnna <[email protected]> feat: added fix for main changes and silly load test example Signed-off-by: RealAnna <[email protected]> feat: added fix for maikefile Signed-off-by: RealAnna <[email protected]> feat: added fix for maikefile Signed-off-by: RealAnna <[email protected]> feat: added more robust init of tests Signed-off-by: RealAnna <[email protected]> feat: go mod Signed-off-by: RealAnna <[email protected]> feat: new developer instructions Signed-off-by: RealAnna <[email protected]> feat: added simple test reporter and load test fake metrics Signed-off-by: RealAnna <[email protected]> feat: added description on reporters Signed-off-by: RealAnna <[email protected]> feat: cleanup Signed-off-by: RealAnna <[email protected]> feat: cleanup Signed-off-by: RealAnna <[email protected]> feat: cleanup Signed-off-by: RealAnna <[email protected]> feat: cleanup Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
mowies
reviewed
Nov 7, 2022
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
RealAnna
force-pushed
the
poc/create_first_tests
branch
from
November 7, 2022 09:43
f8c3d73
to
c4a44b7
Compare
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
thschue
previously requested changes
Nov 7, 2022
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
thisthat
reviewed
Nov 7, 2022
thisthat
reviewed
Nov 7, 2022
thisthat
reviewed
Nov 7, 2022
thisthat
changed the title
feat: Created first example tests
feat: bootstrap webhook/component/integration/performance tests
Nov 7, 2022
Signed-off-by: RealAnna <[email protected]>
mowies
changed the title
feat: bootstrap webhook/component/integration/performance tests
feat: Bootstrap webhook/component/integration/performance tests
Nov 7, 2022
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
mowies
approved these changes
Nov 7, 2022
thisthat
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#173
Research results
While DT uses fakeclients mostly, all other operator repo uses kubebuilder and ginkgo combo for E2E tests.
An example of suite test with configs file to setup testenv is here
Example of webhook test is here
An example of integration/Component test is here
Example integration test with kuttl
Kubebatch scheduler uses ginkgo also for performance/load tests https://github.com/kubernetes-sigs/kube-batch/tree/master/test/kubemark
Poc Description
In this Poc there are examples made for the operator and for the scheduler. Unit test uses a fakeclient while E2E/Component and load tests use kubebuilder+ testenv+ ginkgo. An integration test for the full cluster uses kuttl.
A simple report is generated for component and e2e tests:
Also a simple load test report :
Overall AppVersions created 100/100 Creation times: [2022-10-28 12:45:04.3396049 ...
Instructions on contributions are available :
component test instructions
e2e instructions
make file has been updated to have performance test, e2e and unit test too
Further improvements