Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(metrics-operator): add HPA integration test #2195

Merged
merged 9 commits into from
Sep 28, 2023
Merged

test(metrics-operator): add HPA integration test #2195

merged 9 commits into from
Sep 28, 2023

Conversation

RealAnna
Copy link
Contributor

closes #950

@RealAnna RealAnna requested a review from a team as a code owner September 28, 2023 11:53
@netlify
Copy link

netlify bot commented Sep 28, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 888b2c5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651569540507a0000828ebc3
😎 Deploy Preview https://deploy-preview-2195--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RealAnna RealAnna changed the title chore(test): add hpa test test(metrics-operator): add hpa test Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #2195 (e0f3e3b) into main (fef0dfd) will increase coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
+ Coverage   84.55%   84.60%   +0.05%     
==========================================
  Files         154      154              
  Lines        9918     9918              
==========================================
+ Hits         8386     8391       +5     
+ Misses       1246     1242       -4     
+ Partials      286      285       -1

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 59.82% <ø> (+1.71%) ⬆️
lifecycle-operator 85.02% <ø> (ø)
metrics-operator 87.38% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title test(metrics-operator): add hpa test test(metrics-operator): add HPA integration test Sep 28, 2023
@RealAnna
review
f8a4dd1 
Signed-off-by: realanna <[email protected]>
@RealAnna
review
f54bbb1 
Signed-off-by: realanna <[email protected]>
@RealAnna
increse limits
5e702da 
Signed-off-by: realanna <[email protected]>
@RealAnna
increse limits
b2d42f0 
Signed-off-by: realanna <[email protected]>
@RealAnna
increse limits
e0f3e3b 
Signed-off-by: realanna <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 4342d33 into main Sep 28, 2023
33 checks passed
@RealAnna RealAnna deleted the chore/add_test_for_hpa branch September 28, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Kuttl test for HPA
3 participants
@RealAnna @bacherfl @odubajDT