Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics-operator): refactor fetching resouce namespaces during analysis #2105

Merged
merged 6 commits into from
Sep 18, 2023
Merged

chore(metrics-operator): refactor fetching resouce namespaces during analysis #2105

merged 6 commits into from
Sep 18, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Sep 15, 2023

Changes

  • adapt fetching the right namespace for:
    • analysisDefinition in analysis
    • analysisValueTemplate in analysisDefinition
    • provider in analysisValueTemplate
  • unit tests
  • adapt integration test

Fixes: #2099

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit e137aca
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65041306a7b09d0008cd42e1
😎 Deploy Preview https://deploy-preview-2105--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2105 (8d5912f) into main (34c9d11) will increase coverage by 0.05%.
The diff coverage is 94.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
+ Coverage   84.26%   84.31%   +0.05%     
==========================================
  Files         150      151       +1     
  Lines        9597     9596       -1     
==========================================
+ Hits         8087     8091       +4     
+ Misses       1223     1220       -3     
+ Partials      287      285       -2     
Files Changed Coverage Δ
...operator/controllers/analysis/provider_selector.go 84.41% <80.00%> (+6.10%) ⬆️
metrics-operator/api/v1alpha3/common.go 100.00% <100.00%> (ø)
...etrics-operator/controllers/analysis/controller.go 68.47% <100.00%> (+2.52%) ⬆️
...controllers/common/analysis/objective_evaluator.go 93.18% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.89% <ø> (-0.28%) ⬇️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 86.45% <94.11%> (+0.35%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review September 15, 2023 11:01
@odubajDT odubajDT requested a review from a team as a code owner September 15, 2023 11:01
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 38c8332 into keptn:main Sep 18, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants