fix: add 404 page to the docs #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Liva <[email protected]>
github-actions
bot
added
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
thisthat
commented
Sep 11, 2023
Signed-off-by: Giovanni Liva <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Sep 11, 2023
bacherfl
approved these changes
Sep 11, 2023
|
@thisthat the 404 page doesn't seem to work for me with random gibberish links on the lifecycle.keptn.sh page... |
|
@mowies this is not live yet you need to test on the dev branch. For example: https://main.lifecycle.keptn.sh/docs/doesntexist |
|
Ah makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2051
404 page: https://deploy-preview-2071--keptn-lifecycle-toolkit.netlify.app/404/
Redirect rules do not apply on Netlify for this branch build :/
