Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: begin official word list for Keptn documentation #2049

Merged
merged 11 commits into from
Oct 5, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Sep 7, 2023

Closes #812

This is the beginning of an "official" list of terminology and how to use it in Keptn docs. I don't see us ever doing a big effort to come up with such a list but, by starting the list, we can add to it as issues arise.

This first iteration has two entries: Keptn and CRD/resources. See if you agree with what I wrote here. Also suggests other terms that should be included now.

Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Sep 7, 2023
@StackScribe StackScribe requested a review from a team as a code owner September 7, 2023 06:47
@StackScribe StackScribe self-assigned this Sep 7, 2023
@StackScribe StackScribe requested a review from a team as a code owner September 7, 2023 06:47
@StackScribe StackScribe added this to the 0.9 milestone Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 24fbd0d
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651cf73c8b4d7d00081757b9
😎 Deploy Preview https://deploy-preview-2049--keptn-lifecycle-toolkit.netlify.app/contribute/docs/word-list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mowies and others added 4 commits September 7, 2023 09:50
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@github-actions github-actions bot added the stale label Sep 29, 2023
@RealAnna RealAnna removed the stale label Sep 29, 2023
RealAnna
RealAnna previously approved these changes Sep 29, 2023
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

RealAnna
RealAnna previously approved these changes Oct 2, 2023
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :) The content looks good, just the CI is failing. But from what I see the problems are not caused by the content of this PR. Maybe you can rebase to main branch before we merge? It's up to you :)

@StackScribe
Copy link
Contributor Author

All doc PRs are failing CI until we merge Anna's umbrella charts PR -- I don't think rebasing will help right now.

@odubajDT odubajDT merged commit a656512 into keptn:main Oct 5, 2023
11 of 14 checks passed
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Co-authored-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Style Guide and Word List
4 participants