Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info to implementing/tasks about sequential execution #1950

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Aug 25, 2023

Closes #1949

Draft status while I do some rewriting in response to Adam's remarks.

Answers the question: "Is there a way to define a given order for execution post-deployment tasks in Keptn KLT?"

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Aug 25, 2023
@StackScribe StackScribe added this to the 0.9 milestone Aug 25, 2023
@StackScribe StackScribe requested a review from a team as a code owner August 25, 2023 05:42
@StackScribe StackScribe self-assigned this Aug 25, 2023
@StackScribe StackScribe requested a review from a team as a code owner August 25, 2023 05:42
@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 203e49b
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f58ada469c3100086bc1db
😎 Deploy Preview https://deploy-preview-1950--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here confuses me.

To the question: "Can KeptnTasks be executed in sequential order", the text first essentially says: "No":

All KeptnTaskDefinition resources at the same level
(either pre-deployment or post-deployment) execute in parallel.

That's very clear.

But then towards the end of the page:

Perhaps you need to run a set of integration tests, a set of performance tests, and a set of regression tests.

Yes, perfect. Let's say I need to run integration tests first then regression (and only if they pass) performance tests.

Define one KeptnTaskDefinition resource that runs
integration tests, then regression test, then performance tests
in order.

So, I seem to have two answers: I cannot execute sequentially, but also, I can. Which is it?

@StackScribe StackScribe marked this pull request as draft August 31, 2023 10:02
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe marked this pull request as ready for review September 1, 2023 05:45
@StackScribe
Copy link
Contributor Author

@agardnerIT Thanks for this excellent critique. I did a rewrite of all of this -- see if it makes more sense now. The answer is that all KeptnTask resources that are defined as annotations to the KeptnApp resource for a specific stage execute in parallel but one KeptnTask resource can run many executables in order. Moreover, you can define a "parent" KeptnTaskDefinition that uses the functionRef syntax to run other KeptnTask resources in sequence, but only the parent KeptnTaskDefinition is specified in the KeptnApp annotations.

StackScribe and others added 2 commits September 1, 2023 01:50
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Signed-off-by: Meg McRoberts <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 61f92c3 into keptn:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain how to execute multiple tasks in sequential order
4 participants