Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): update dql provider to include range #1919

Merged
merged 14 commits into from
Aug 24, 2023

Conversation

rakshitgondwal
Copy link
Member

Fixes #1918

@rakshitgondwal rakshitgondwal requested a review from a team as a code owner August 22, 2023 09:35
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit b1ac310
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e5cf2d4d36090008d661e9
😎 Deploy Preview https://deploy-preview-1919--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1919 (0f06f37) into main (2a6bc6a) will increase coverage by 0.05%.
The diff coverage is 82.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
+ Coverage   83.94%   84.00%   +0.05%     
==========================================
  Files         141      141              
  Lines        8641     8702      +61     
==========================================
+ Hits         7254     7310      +56     
- Misses       1129     1132       +3     
- Partials      258      260       +2     
Files Changed Coverage Δ
...ollers/common/providers/dynatrace/client/client.go 69.31% <57.14%> (ø)
...ollers/common/providers/dynatrace/dynatrace_dql.go 82.96% <85.05%> (+3.62%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.07% <ø> (+0.61%) ⬆️
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 86.03% <82.97%> (+0.16%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
rakshitgondwal and others added 5 commits August 22, 2023 19:19
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust DQL provider to include range
4 participants