Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add better instructions for OTel example #1896

Merged
merged 4 commits into from
Sep 19, 2023
Merged

docs: add better instructions for OTel example #1896

merged 4 commits into from
Sep 19, 2023

Conversation

ShivangShandilya
Copy link
Contributor

@ShivangShandilya ShivangShandilya commented Aug 16, 2023 •
edited
Loading

This PR fixes: #1748

Adding an instruction above the commands to clone the repo and cd into the current directory.

@ShivangShandilya ShivangShandilya requested review from a team as code owners August 16, 2023 15:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 16, 2023
@netlify
Copy link

netlify bot commented Aug 16, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c3c436a
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6509885309457a0008c8f5db
😎 Deploy Preview https://deploy-preview-1896--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mowies
mowies requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the solution here. The --server-side flag does exist in stable kubectl versions since v1.22
[source]

@ShivangShandilya
Copy link
Contributor Author

I don't think this is the solution here. The --server-side flag does exist in stable kubectl versions since v1.22 [source]

Ohh I didn't about --server-side flag with the apply command. Thanks @mowies for providing the source, was able to read about it in detail. Also, do tell me what changes are required for the issue because everything else seems correct to me

@mowies
Copy link
Member

mowies commented Aug 22, 2023

I don't actually know what the problem is here, so I also don't have a solution for you. Maybe @agardnerIT can shine some light onto this, he reported the ticket in the first place.

@ShivangShandilya ShivangShandilya changed the title docs: update kubectl command docs: add instruction above commands Aug 24, 2023
mowies
mowies reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed the formatting to use the special note design and also added the directory that users need to change into

docs/content/en/docs/implementing/otel.md Outdated Show resolved Hide resolved
@mowies mowies changed the title docs: add instruction above commands docs: add better instructions for OTel example Aug 28, 2023
mowies
mowies previously approved these changes Aug 30, 2023
View reviewed changes
@odubajDT
Copy link
Contributor

Hello @ShivangShandilya , thank you for your contribution!
Please run make markdownlint-fix to fix the failing tests

ShivangShandilya and others added 4 commits September 19, 2023 13:38
@ShivangShandilya @RealAnna
Update otel.md
048f1bf 
Signed-off-by: Shivang Shandilya <[email protected]>
@ShivangShandilya @RealAnna
Update otel.md
908b44c 
Signed-off-by: Shivang Shandilya <[email protected]>
@ShivangShandilya @mowies @RealAnna
Update docs/content/en/docs/implementing/otel.md
dbb9959 
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Shivang Shandilya <[email protected]>
@ShivangShandilya @StackScribe @RealAnna
Update docs/content/en/docs/implementing/otel.md
c3c436a 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: Shivang Shandilya <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT
Copy link
Contributor

@ShivangShandilya thank you for your contribution!

@odubajDT odubajDT merged commit f034265 into keptn:main Sep 19, 2023
14 checks passed
@keptn-bot keptn-bot mentioned this pull request Sep 19, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@odubajDT odubajDT odubajDT approved these changes

@bacherfl bacherfl bacherfl approved these changes

@mowies mowies mowies left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/docs/implementing/otel/_index.md kubectl apply --server-side -f config/prometheus/setup wrong
5 participants
@ShivangShandilya @mowies @odubajDT @bacherfl @StackScribe