Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add helm template check #1859

Merged
merged 14 commits into from
Aug 10, 2023
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Aug 8, 2023

add a default helm template to test for changes, more folders with other tests can be added later on to verify our umbrella chart features

Uploading image.png…

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 193061c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d4a00887a7880008194844
😎 Deploy Preview https://deploy-preview-1859--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1859 (521a175) into main (5b47120) will decrease coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
- Coverage   83.42%   83.37%   -0.05%     
==========================================
  Files         136      136              
  Lines        8348     8348              
==========================================
- Hits         6964     6960       -4     
- Misses       1127     1130       +3     
- Partials      257      258       +1     

see 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.13% <ø> (-1.64%) ⬇️
lifecycle-operator 84.88% <ø> (ø)
metrics-operator 82.95% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna changed the title chore(ci): add helm template check ci: add helm template check Aug 8, 2023
@github-actions github-actions bot removed the helm label Aug 9, 2023
@RealAnna RealAnna force-pushed the chore/add_back_a_validation_of_helm_chart branch from 7f0d973 to 98910fe Compare August 9, 2023 13:15
@github-actions github-actions bot added the helm label Aug 9, 2023
@RealAnna RealAnna force-pushed the chore/add_back_a_validation_of_helm_chart branch from d7b363e to fe76c82 Compare August 9, 2023 13:45
@RealAnna RealAnna marked this pull request as ready for review August 9, 2023 14:11
@RealAnna RealAnna requested a review from a team as a code owner August 9, 2023 14:11
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please rename the folder to .helm-tests?

.github/scripts/helm-test.sh Outdated Show resolved Hide resolved
bacherfl
bacherfl previously approved these changes Aug 10, 2023
@RealAnna RealAnna requested a review from a team as a code owner August 10, 2023 08:16
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 10, 2023
@RealAnna RealAnna force-pushed the chore/add_back_a_validation_of_helm_chart branch from 6b10355 to 193061c Compare August 10, 2023 08:29
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Aug 10, 2023
RealAnna and others added 6 commits August 10, 2023 11:50
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: realanna <[email protected]>
@RealAnna RealAnna force-pushed the chore/add_back_a_validation_of_helm_chart branch from 66e73c1 to 521a175 Compare August 10, 2023 09:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 193f520 into main Aug 10, 2023
@RealAnna RealAnna deleted the chore/add_back_a_validation_of_helm_chart branch August 10, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants