-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: monorepo setup for lifecycle-operator, scheduler and runtimes #1857
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
- Coverage 83.94% 83.91% -0.03%
==========================================
Files 142 142
Lines 8817 8845 +28
==========================================
+ Hits 7401 7422 +21
- Misses 1152 1157 +5
- Partials 264 266 +2 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the example folder and in the samples we sometimes use reference to raw git url to the sample runtimes, can you make sure those are correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for docs changes. One tiny note for consideration but not a blocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking 'till release
Signed-off-by: Moritz Wiesinger <[email protected]>
…m chart docs Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]> This reverts commit 0d4d4ff.
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
This PR
runtimes
sub-folderNotes
I left some comments on the PR to explain things.
Integration tests are failing because they reference files that don't exist on main branch yet.
Same with link checks.