Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monorepo setup for lifecycle-operator, scheduler and runtimes #1857

Merged
merged 52 commits into from
Aug 29, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 8, 2023

This PR

  • fixes Rename function-runtime folder to deno-runtime #1710
    • renames functions-runtime to deno-runtime
    • moves runtimes into the runtimes sub-folder
  • fixes Monorepo setup for lifecycle operator #1598
  • creates more monorepo artifacts:
    • lifecycle-operator
    • deno-runtime
    • python-runtime
    • scheduler
  • groups lifecycle-operator and scheduler artifacts together into one release PR
  • removes k8s manifests from being released (to test the full thing, separate PR chore: remove generation of KLT manifest releases #1850 is open and on hold until KLT 0.8.2 is released)
  • fixes a wrong link to a docs snippet in the readme and removes the now unneeded docs snippet
  • updates the installation docs to point out that the manifests are no longer supported (debatable if this is needed since manifests will be supported, just differently in the future)
  • removes most release-please annotation comments since most things are their own releases now

Notes

I left some comments on the PR to explain things.
Integration tests are failing because they reference files that don't exist on main branch yet.
Same with link checks.

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit a5fab48
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64ed96785c9d5900081a3fc0
😎 Deploy Preview https://deploy-preview-1857--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1857 (a5fab48) into main (972b3bb) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   83.94%   83.91%   -0.03%     
==========================================
  Files         142      142              
  Lines        8817     8845      +28     
==========================================
+ Hits         7401     7422      +21     
- Misses       1152     1157       +5     
- Partials      264      266       +2     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.07% <ø> (+0.20%) ⬆️
keptn-lifecycle-operator ?
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 85.40% <ø> (-0.17%) ⬇️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/validate-semantic-pr.yml Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
release-please-config.json Show resolved Hide resolved
@mowies mowies added the on hold Do not merge yet label Aug 8, 2023
@mowies mowies marked this pull request as ready for review August 8, 2023 11:19
@mowies mowies requested review from a team as code owners August 8, 2023 11:19
@mowies mowies changed the title feat: monorepo setup for lifecycle-operator and runtimes feat: monorepo setup for lifecycle-operator, scheduler and runtimes Aug 8, 2023
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the example folder and in the samples we sometimes use reference to raw git url to the sample runtimes, can you make sure those are correct ?

for example https://github.com/mowies/lifecycle-controller/blob/main/lifecycle-operator/config/samples/function_execution/taskdefinition_function_upstream.yaml

RealAnna
RealAnna previously approved these changes Aug 9, 2023
odubajDT
odubajDT previously approved these changes Aug 9, 2023
StackScribe
StackScribe previously approved these changes Aug 10, 2023
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs changes. One tiny note for consideration but not a blocker

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking 'till release

mowies added 5 commits August 28, 2023 11:11
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
.github/workflows/load-test.yml Outdated Show resolved Hide resolved
.github/workflows/performance-test.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/validate-semantic-pr.yml Show resolved Hide resolved
docs/content/en/docs/install/install.md Show resolved Hide resolved
docs/content/en/docs/install/install.md Outdated Show resolved Hide resolved
@thisthat thisthat removed the on hold Do not merge yet label Aug 28, 2023
@thisthat thisthat self-requested a review August 28, 2023 13:50
mowies and others added 5 commits August 28, 2023 16:02
Signed-off-by: Moritz Wiesinger <[email protected]>

This reverts commit 0d4d4ff.
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
renovate.json Outdated Show resolved Hide resolved
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename function-runtime folder to deno-runtime Monorepo setup for lifecycle operator
5 participants