chore: move from continuous helmify to custom chart #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: geoffrey1330 <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
- Coverage 83.44% 83.40% -0.04%
==========================================
Files 132 132
Lines 8210 8215 +5
==========================================
+ Hits 6851 6852 +1
- Misses 1106 1109 +3
- Partials 253 254 +1 see 17 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
RealAnna
reviewed
Aug 4, 2023
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
mowies
changed the title
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
RealAnna
reviewed
Aug 7, 2023
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
RealAnna
reviewed
Aug 7, 2023
Signed-off-by: geoffrey1330 <[email protected]>
RealAnna
reviewed
Aug 7, 2023
Signed-off-by: geoffrey1330 <[email protected]>
RealAnna
reviewed
Aug 7, 2023
metrics-operator/config/crd/bases/metrics.keptn.sh_keptnmetrics.yaml
Outdated
Show resolved
Hide resolved
RealAnna
reviewed
Aug 7, 2023
metrics-operator/config/crd/bases/metrics.keptn.sh_keptnmetricsproviders.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
RealAnna
reviewed
Aug 8, 2023
RealAnna
reviewed
Aug 8, 2023
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: realanna <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@geoffrey1330 I think your main is out of sync and some of the template files where not correct due to this, I pushed the fix so now the PR is ready for review 😸 thank you for the contribution! |
Thank you for the help and assistance while working on this issue |
odubajDT
approved these changes
Aug 8, 2023
mowies
approved these changes
Aug 8, 2023
mowies
approved these changes
Aug 8, 2023
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Aug 9, 2023
Signed-off-by: RealAnna <[email protected]> Signed-off-by: realanna <[email protected]> Co-authored-by: RealAnna <[email protected]> Co-authored-by: realanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: geoffrey1330 [email protected]
fixes: #1599