Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improved example on app yamls #1821

Merged
merged 4 commits into from
Aug 16, 2023
Merged

chore: improved example on app yamls #1821

merged 4 commits into from
Aug 16, 2023

Conversation

hirentimbadiya
Copy link
Contributor

@hirentimbadiya hirentimbadiya commented Aug 2, 2023 •
edited by mowies
Loading

This PR Fixes #1813

@RealAnna, could you kindly review this pull request and let me know if there are any additional changes that need to be made? Thank you!

@hirentimbadiya hirentimbadiya requested review from a team as code owners August 2, 2023 11:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 2, 2023
@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 8b714a8
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d275a34ba2c90008bb7243
😎 Deploy Preview https://deploy-preview-1821--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/metrics/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hirentimbadiya hirentimbadiya requested a review from RealAnna August 2, 2023 12:21
@RealAnna RealAnna changed the title improved example on app yamls chore: improved example on app yamls Aug 3, 2023
@hirentimbadiya hirentimbadiya requested a review from RealAnna August 6, 2023 07:50
@hirentimbadiya
Copy link
Contributor Author

@agardnerIT can you review my PR ?

mowies
mowies approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mowies mowies force-pushed the hirentimbadiya1813 branch from 9a3c08f to 59ecad3 Compare August 8, 2023 12:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

thisthat
thisthat approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hirentimbadiya thanks for your contribution :shipit:

@thisthat thisthat merged commit 584138f into keptn:main Aug 16, 2023
@keptn-bot keptn-bot mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies approved these changes

@thisthat thisthat thisthat approved these changes

@RealAnna RealAnna Awaiting requested review from RealAnna

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve example on app yamls to avoid confusion on versioning
4 participants
@hirentimbadiya @thisthat @mowies @RealAnna