Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adapt markdown check trigger to include changes to CRD structs #1818

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Aug 2, 2023

Closes #1817

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 09dd828
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64c9fbaccc331d00088a0722
😎 Deploy Preview https://deploy-preview-1818--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1818 (0c87ca8) into main (604876f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1818   +/-   ##
=======================================
  Coverage   63.60%   63.60%           
=======================================
  Files         143      143           
  Lines       10937    10937           
=======================================
  Hits         6957     6957           
  Misses       3719     3719           
  Partials      261      261           

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.95% <ø> (+0.54%) ⬆️
lifecycle-operator 84.91% <ø> (ø)
metrics-operator 82.73% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl force-pushed the fix/markdown-check branch from ea32b14 to 9ce08b4 Compare August 2, 2023 06:50
Signed-off-by: Florian Bacher <[email protected]>
@mowies mowies changed the title build: adapt markdown check trigger to include changes to CRD structs ci: adapt markdown check trigger to include changes to CRD structs Aug 2, 2023
Signed-off-by: Florian Bacher <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review August 2, 2023 07:30
@bacherfl bacherfl requested a review from a team as a code owner August 2, 2023 07:30
@mowies mowies merged commit ee2abea into keptn:main Aug 2, 2023
@bacherfl bacherfl deleted the fix/markdown-check branch August 2, 2023 08:29
prakrit55 pushed a commit to prakrit55/lifecycle-toolkit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown checks are not executed for PRs making changes in api directories of the operators
3 participants