feat: add grafana labels to work with kube-prometheus-stack #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Gardner <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
==========================================
+ Coverage 63.59% 63.92% +0.32%
==========================================
Files 143 143
Lines 10925 11104 +179
==========================================
+ Hits 6948 7098 +150
- Misses 3716 3742 +26
- Partials 261 264 +3 see 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
previously approved these changes
Jul 25, 2023
mowies
reviewed
Jul 25, 2023
examples/support/observability/config/prometheus/grafana-dashboard-keptn-overview.yaml
Outdated
Show resolved
Hide resolved
examples/support/observability/config/prometheus/grafana-dashboard-keptn-workloads.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mowies
approved these changes
Jul 25, 2023
odubajDT
approved these changes
Jul 25, 2023
RealAnna
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
grafana_dashboard: "1"label to each dashboardThis label means the grafana dashboards will automatically appear when someone installs Grafana via kube-prometheus-stack