Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: excercises text changed to exercises #1693

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

Saurav-Pant
Copy link
Contributor

Fixes: #1684

Here I changed excercises text to exercises

@Saurav-Pant Saurav-Pant requested review from a team as code owners July 7, 2023 11:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 7, 2023
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 10f7dce
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64a7fa5883cb2d00084d08a1
😎 Deploy Preview https://deploy-preview-1693--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@agardnerIT
Copy link
Contributor

Please sign off your commit as explained by clicking the "Details" link above.

@agardnerIT agardnerIT changed the title excercises text changed to exercises docs: excercises text changed to exercises Jul 11, 2023
@Saurav-Pant
Copy link
Contributor Author

Please sign off your commit as explained by clicking the "Details" link above.

can you please tell me where is details link, I am unable to find @agardnerIT

@agardnerIT
Copy link
Contributor

Please sign off your commit as explained by clicking the "Details" link above.

can you please tell me where is details link, I am unable to find @agardnerIT

Below your message, where it says "Some checks were not successful" there is a line item for "DCO" and along the right hand side there's a hyperlink to a Details Page. This is the direct link.

When on that page, scroll down to the bottom and you'll see the copy / paste git commands to sign your commit.

Sorry, I know this is painful but it's a requirement of all CNCF projects.

To help, you can do this easily next time by adding the -s flag to your git commit: git commit -sm "my commit message"

You can also create a pre-commit hook in case you forget: see here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Saurav-Pant
Copy link
Contributor Author

@agardnerIT, Thanks for telling me, I updated this

@odubajDT odubajDT merged commit df4cda6 into keptn:main Jul 12, 2023
@odubajDT
Copy link
Contributor

Hi @Saurav-Pant, thank you for your contribution! :)

Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo: excercises
4 participants