feat: update Prometheus API to query metrics over a range #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakshit Gondwal <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
+ Coverage 63.34% 63.45% +0.10%
==========================================
Files 142 142
Lines 10822 10892 +70
==========================================
+ Hits 6855 6911 +56
- Misses 3710 3719 +9
- Partials 257 262 +5
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
reviewed
Jun 22, 2023
bacherfl
reviewed
Jun 22, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
bacherfl
reviewed
Jun 26, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jun 26, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Jun 26, 2023
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
bacherfl
reviewed
Jun 28, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
…tResultForVector Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
bacherfl
reviewed
Jun 29, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus.go
Outdated
Show resolved
Hide resolved
…theus.go Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Rakshit Gondwal <[email protected]>
bacherfl
reviewed
Jun 29, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Rakshit Gondwal <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Jun 29, 2023
odubajDT
approved these changes
Jun 30, 2023
|
@rakshitgondwal thank you for contribution! :) |
|
Thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes (#1012)
Dependency: #1471
Changes made:
prometheus.goto query metrics over a time frame