Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix security pipeline #1582

Merged
merged 1 commit into from
Jun 19, 2023
Merged

ci: fix security pipeline #1582

merged 1 commit into from
Jun 19, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Jun 19, 2023

This PR

  • fixes an issue in the security scan pipeline where it tried to download manifests that don't exist anymore. the test manifests are the ones that should be used
    related: fix: fail security scan #1564

Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added the ops label Jun 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1582 (3820dd3) into main (fe5bbea) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
- Coverage   63.26%   63.15%   -0.11%     
==========================================
  Files         142      142              
  Lines       10784    10784              
==========================================
- Hits         6822     6811      -11     
- Misses       3707     3714       +7     
- Partials      255      259       +4     

see 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.70% <ø> (+0.60%) ⬆️
lifecycle-operator 84.48% <ø> (ø)
metrics-operator 81.66% <ø> (ø)
scheduler 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies marked this pull request as ready for review June 19, 2023 12:23
@mowies mowies requested a review from a team as a code owner June 19, 2023 12:23
@mowies mowies merged commit 74c7426 into main Jun 19, 2023
@mowies mowies deleted the fix-security-scans branch June 19, 2023 13:16
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jun 20, 2023
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jun 20, 2023
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants