Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove old "Tasks" section from docs #1572

Merged
merged 4 commits into from
Jun 20, 2023
Merged

docs: remove old "Tasks" section from docs #1572

merged 4 commits into from
Jun 20, 2023
+64 −91

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Jun 17, 2023 •
edited
Loading

The "Tasks" section is a vestige of the old doc set. The title was confusing -- this was a miscellaneous section about various things one could do, not about Keptn tasks specifically. Most of the old content has already been relocated to other locations; this gets rid of this section.

Specifically, this PR does the following:

  • Move the "Restart an Application Deployment" page to "Implementing..."
    • I had not planned to modify the content of this file but it really needed an edit so I did that while I was at it.
  • Move the "Add Application Awareness" file to "Implementing". This page is not currently building in the docs but contains some interesting information that should be incorporated into the docs so we'll preserve it.
  • Delete the copy of "Implement Slack Notifications" since it was previously copied to "Implementing"
  • Delete the "Evaluate Metrics" page since it has no content. We will eventually provide docs about this.
  • Add links from the KeptnApp reference page to the "Restart an Applicaion Deployment" page

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jun 17, 2023
@StackScribe StackScribe requested a review from a team as a code owner June 17, 2023 06:03
@StackScribe StackScribe self-assigned this Jun 17, 2023
@StackScribe StackScribe requested a review from a team as a code owner June 17, 2023 06:03
@netlify
Copy link

netlify bot commented Jun 17, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 8953eb3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6491793a8b7d2f000854ad6c
😎 Deploy Preview https://deploy-preview-1572--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@StackScribe
markdownlint issues, edits
88d8dc4 
Signed-off-by: Meg McRoberts <[email protected]>
thisthat
thisthat previously approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment - otherwise LGTM :)

docs/content/en/docs/implementing/restart-application-deployment/_index.md Outdated Show resolved Hide resolved
odubajDT
odubajDT reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :) Please just adapt the changes regarding Giovanni's comment, otherwise LGTM

odubajDT
odubajDT previously approved these changes Jun 20, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 8f0f4f0 into keptn:main Jun 20, 2023
@keptn-bot keptn-bot mentioned this pull request Jun 20, 2023
Merged
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jun 20, 2023
@StackScribe @odubajDT @Nitishupkr
docs: remove old "Tasks" section from docs (keptn#1572)
c95e6ef 
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Nitishupkr <[email protected]>
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
@StackScribe @odubajDT
docs: remove old "Tasks" section from docs (keptn#1572)
7836789 
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: odubajDT <[email protected]>
@keptn-bot keptn-bot mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat thisthat left review comments

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StackScribe @thisthat @bacherfl @RealAnna @odubajDT