Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update module github.com/onsi/ginkgo/v2 to v2.11.0 #1553

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 13, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/onsi/ginkgo/v2 require minor v2.9.7 -> v2.11.0

Release Notes

onsi/ginkgo

v2.11.0

Compare Source

2.11.0

In prior versions of Ginkgo specs the CLI filter flags (e.g. --focus, --label-filter) would override any programmatic focus. This behavior has proved surprising and confusing in at least the following ways:

  • users cannot combine programmatic filters and CLI filters to more efficiently select subsets of tests
  • CLI filters can override programmatic focus on CI systems resulting in an exit code of 0 despite the presence of (incorrectly!) committed focused specs.

Going forward Ginkgo will AND all programmatic and CLI filters. Moreover, the presence of any programmatic focused tests will always result in a non-zero exit code.

This change is technically a change in Ginkgo's external contract and may require some users to make changes to successfully adopt. Specifically: it's possible some users were intentionally using CLI filters to override programmatic focus. If this is you please open an issue so we can explore solutions to the underlying problem you are trying to solve.

Fixes
  • Programmatic focus is no longer overwrriten by CLI filters [d6bba86]
Maintenance

v2.10.0

Compare Source

2.10.0

Features
  • feat(ginkgo/generators): add --tags flag (#​1216) [a782a77]
    adds a new --tags flag to ginkgo generate
Fixes
Maintenance

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner June 13, 2023 00:51
@renovate
Copy link
Contributor Author

renovate bot commented Jun 13, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: scheduler/go.sum
Command failed: docker run --rm --name=renovate_a_sidecar --label=renovate_a_child -v "/tmp/worker/a3cfe6/59ee91/repos/github/keptn/lifecycle-toolkit":"/tmp/worker/a3cfe6/59ee91/repos/github/keptn/lifecycle-toolkit" -v "/tmp/worker/a3cfe6/59ee91/cache":"/tmp/worker/a3cfe6/59ee91/cache" -e GOPATH -e GOPROXY -e GOSUMDB -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -e GIT_CONFIG_KEY_2 -e GIT_CONFIG_VALUE_2 -e GIT_CONFIG_COUNT -e BUILDPACK_CACHE_DIR -e CONTAINERBASE_CACHE_DIR -w "/tmp/worker/a3cfe6/59ee91/repos/github/keptn/lifecycle-toolkit/scheduler" ghcr.io/containerbase/sidecar bash -l -c "install-tool golang 1.20.5 && go get -d -t ./... && go mod tidy && go mod tidy"
go: k8s.io/[email protected]: reading k8s.io/kube-scheduler/go.mod at revision v0.0.0: unknown revision v0.0.0

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 43e0d75
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64908f900fd3c50008549b83
😎 Deploy Preview https://deploy-preview-1553--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1553 (09a27f8) into main (74c7426) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
- Coverage   63.30%   63.20%   -0.11%     
==========================================
  Files         142      142              
  Lines       10784    10784              
==========================================
- Hits         6827     6816      -11     
- Misses       3703     3711       +8     
- Partials      254      257       +3     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.49% <ø> (-1.49%) ⬇️
lifecycle-operator 84.48% <ø> (ø)
metrics-operator 81.66% <ø> (ø)
scheduler 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/github.com-onsi-ginkgo-v2-2.x branch from d1fc584 to 43e0d75 Compare June 19, 2023 17:25
@renovate renovate bot changed the title deps: update module github.com/onsi/ginkgo/v2 to v2.10.0 deps: update module github.com/onsi/ginkgo/v2 to v2.11.0 Jun 19, 2023
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@renovate
Copy link
Contributor Author

renovate bot commented Jun 20, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@odubajDT odubajDT merged commit 7c4d2ab into main Jun 20, 2023
@odubajDT odubajDT deleted the renovate/github.com-onsi-ginkgo-v2-2.x branch June 20, 2023 11:21
@keptn-bot keptn-bot mentioned this pull request Jun 20, 2023
Nitishupkr pushed a commit to Nitishupkr/lifecycle-toolkit that referenced this pull request Jun 20, 2023
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Nitishupkr <[email protected]>
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants