Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove requirement for semantic commit in single-commit PRs #1535

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Jun 7, 2023

This PR

  • disables the semantic PR check for single commit PRs preventing PRs to be merged that have a single commit that is not semantic. This is not needed anymore since github introduced a setting to always use the PR title as the commit message during squash and merge.

@mowies mowies requested a review from a team as a code owner June 7, 2023 11:36
@github-actions github-actions bot added the ops label Jun 7, 2023
@netlify
Copy link

netlify bot commented Jun 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 189510a
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64806bdcbbe71300084652a0
😎 Deploy Preview https://deploy-preview-1535--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies
Copy link
Member Author

mowies commented Jun 7, 2023

This will hopefully be appreciated by @agardnerIT 😅

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #1535 (189510a) into main (c732492) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
+ Coverage   63.04%   63.07%   +0.02%     
==========================================
  Files         142      142              
  Lines       10779    10779              
==========================================
+ Hits         6796     6799       +3     
+ Misses       3724     3722       -2     
+ Partials      259      258       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.14% <ø> (+0.20%) ⬆️
lifecycle-operator 84.35% <ø> (ø)
metrics-operator 81.66% <ø> (ø)
scheduler 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies merged commit 5aa5eb4 into keptn:main Jun 7, 2023
@mowies mowies deleted the remove-semantic-single-commit-check branch June 7, 2023 12:06
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 19, 2023
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants