Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): bump OTel dependencies to the latest version #1419

Merged
merged 1 commit into from
May 17, 2023
Merged

chore(operator): bump OTel dependencies to the latest version #1419

merged 1 commit into from
May 17, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented May 15, 2023

Fixes: #1417

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 2716761
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6464742e27d016000847ff8f
😎 Deploy Preview https://deploy-preview-1419--keptn-lifecycle-toolkit.netlify.app/docs/yaml-crd-ref/config
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1419 (ccd89cc) into main (e40292c) will decrease coverage by 0.04%.
The diff coverage is 63.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   61.66%   61.62%   -0.04%     
==========================================
  Files         137      137              
  Lines       10480    10471       -9     
==========================================
- Hits         6462     6453       -9     
  Misses       3766     3766              
  Partials      252      252              
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha1/common/common.go 100.00% <ø> (ø)
operator/apis/lifecycle/v1alpha2/common/common.go 100.00% <ø> (ø)
operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <ø> (ø)
...ator/controllers/lifecycle/keptntask/controller.go 54.94% <0.00%> (-3.30%) ⬇️
operator/controllers/common/otel_utils.go 74.17% <54.28%> (-1.05%) ⬇️
operator/controllers/common/metrics.go 79.41% <100.00%> (ø)
...ontrollers/lifecycle/keptnappversion/controller.go 78.19% <100.00%> (ø)
...ontrollers/lifecycle/keptnevaluation/controller.go 76.43% <100.00%> (ø)
...lers/lifecycle/keptnworkloadinstance/controller.go 80.75% <100.00%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.31% <50.00%> (ø)
lifecycle-operator 83.14% <63.26%> (-0.05%) ⬇️
metrics-operator 80.47% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title bump deps chore(operator): bump OTel dependencies to the latest version May 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.8% 5.8% Duplication

@odubajDT odubajDT marked this pull request as ready for review May 17, 2023 06:58
@odubajDT odubajDT requested a review from a team as a code owner May 17, 2023 06:58
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Screenshot 2023-05-17 at 12 12 02

tried it out with this branch and can verify that it's working

@odubajDT odubajDT merged commit a7475c2 into keptn:main May 17, 2023
@keptn-bot keptn-bot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: support OTel 1.15
3 participants