Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the general guidelines section #1373

Closed
wants to merge 3 commits into from

Conversation

YashPimple
Copy link
Member

Related to #972
Fixes #995

Signed-off-by: Yash Pimple [email protected]

@YashPimple YashPimple requested review from a team as code owners May 4, 2023 18:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 3886f4d
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6454a23b42ee5500086076ba
😎 Deploy Preview https://deploy-preview-1373--keptn-lifecycle-toolkit.netlify.app/contribute/software/guidelines-for-contributing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@YashPimple YashPimple closed this May 4, 2023
@YashPimple YashPimple reopened this May 4, 2023
YashPimple added 2 commits May 5, 2023 11:52
Signed-off-by: Yash Pimple <[email protected]>
Signed-off-by: Yash Pimple <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

* If you want to do the work on an issue,
include that information in your description of the issue
or in a comment to the issue.
## [Guidelines for contributing](docs/content/en/contribute/software/guidelines-for-contributing/_index.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not put links into headings - it makes it really hard to detect them as links.

@YashPimple YashPimple closed this May 5, 2023
@YashPimple YashPimple deleted the guidelines branch August 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing: general guidelines
2 participants