Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): introduce fallback search to KLT default namespace when KeptnTaskDefinition is not found #1340

Merged
merged 4 commits into from
May 3, 2023
Merged

feat(operator): introduce fallback search to KLT default namespace when KeptnTaskDefinition is not found #1340

merged 4 commits into from
May 3, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented May 2, 2023

Fixes: #1338

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c62754b
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6450ff197cdc490008216bb2
😎 Deploy Preview https://deploy-preview-1340--keptn-lifecycle-toolkit.netlify.app/docs/concepts/apps
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1340 (aa24c00) into main (cc03a85) will increase coverage by 0.03%.
The diff coverage is 77.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   61.21%   61.24%   +0.03%     
==========================================
  Files         138      138              
  Lines       10459    10471      +12     
==========================================
+ Hits         6402     6413      +11     
- Misses       3805     3806       +1     
  Partials      252      252              
Impacted Files Coverage Δ
...ollers/common/providers/keptnmetric/keptnmetric.go 85.18% <0.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 40.54% <50.00%> (ø)
operator/controllers/common/helperfunctions.go 98.41% <92.30%> (-1.59%) ⬇️
operator/controllers/common/taskhandler.go 79.56% <100.00%> (-0.15%) ⬇️
Flag Coverage Δ
certificate-operator 64.28% <ø> (ø)
component-tests 59.72% <50.00%> (+0.22%) ⬆️
lifecycle-operator 82.53% <77.77%> (+0.04%) ⬆️
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review May 2, 2023 12:55
@odubajDT odubajDT requested a review from a team as a code owner May 2, 2023 12:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@odubajDT odubajDT merged commit 6794fe2 into keptn:main May 3, 2023
@keptn-bot keptn-bot mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fallback mechanism to look for KeptnTaskDefinitions
3 participants