Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): Add tracing support #129

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Oct 6, 2022

A single Span is created for the whole scheduling until the Pod is binded to a node. Status changes are reported as events.

		"SpanContext": {
			"TraceID": "44382924dc4e184bf358336002c8ebbe",
			"SpanID": "8eb9ca277492f955",
			"TraceFlags": "01",
			"TraceState": null,
			"Remote": false
		},
		"Parent": {
			"TraceID": "44382924dc4e184bf358336002c8ebbe",
			"SpanID": "029961c2f06e15c8",
			"TraceFlags": "01",
			"TraceState": null,
			"Remote": true
		},
		"SpanKind": 1,
		"Name": "schedule",
		"StartTime": "2022-10-06T17:33:06.220931583Z",
		"EndTime": "2022-10-06T17:33:37.811943595Z",
		"Attributes": [
			{
				"Key": "keptn.deployment.app_name",
				"Value": {
					"Type": "STRING",
					"Value": "waiter"
				}
			},
			{
				"Key": "keptn.deployment.workload",
				"Value": {
					"Type": "STRING",
					"Value": "waiter-waiter"
				}
			},
			{
				"Key": "keptn.deployment.version",
				"Value": {
					"Type": "STRING",
					"Value": "0.2"
				}
			},
			{
				"Key": "keptn.deployment.namespace",
				"Value": {
					"Type": "STRING",
					"Value": "default"
				}
			}
		],
		"MessageEvents": [
			{
				"Name": "StatusEvaluation",
				"Attributes": [
					{
						"Key": "keptn.deployment.status",
						"Value": {
							"Type": "STRING",
							"Value": "Succeeded"
						}
					}
				],
				"DroppedAttributeCount": 0,
				"Time": "2022-10-06T17:33:37.811941482Z"
			}
		],
		"Links": null,
		"StatusCode": "Unset",
		"StatusMessage": "",
		"DroppedAttributeCount": 0,
		"DroppedMessageEventCount": 0,
		"DroppedLinkCount": 0,
		"ChildSpanCount": 0,
		"Resource": [
			{
				"Key": "service.name",
				"Value": {
					"Type": "STRING",
					"Value": "unknown_service:kube-scheduler"
				}
			},
			{
				"Key": "telemetry.sdk.language",
				"Value": {
					"Type": "STRING",
					"Value": "go"
				}
			},
			{
				"Key": "telemetry.sdk.name",
				"Value": {
					"Type": "STRING",
					"Value": "opentelemetry"
				}
			},
			{
				"Key": "telemetry.sdk.version",
				"Value": {
					"Type": "STRING",
					"Value": "0.20.0"
				}
			}
		],
		"InstrumentationLibrary": {
			"Name": "keptn/scheduler",
			"Version": ""
		}
	}

Solves #96

@thisthat thisthat marked this pull request as ready for review October 6, 2022 17:40
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thisthat thisthat merged commit 60651d1 into main Oct 7, 2022
@thisthat thisthat deleted the feat/96/add-tracing-scheduler branch October 7, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants