feat(operator): consider corner cases in KACR controller #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 59.64% 59.79% +0.15%
==========================================
Files 138 138
Lines 10424 10444 +20
==========================================
+ Hits 6217 6245 +28
+ Misses 3971 3965 -6
+ Partials 236 234 -2
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
thisthat
previously approved these changes
Apr 24, 2023
operator/controllers/lifecycle/keptnappcreationrequest/controller.go
Outdated
Show resolved
Hide resolved
operator/controllers/lifecycle/keptnappcreationrequest/controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <[email protected]>
…eat/kacr-corner-cases-2
Signed-off-by: Florian Bacher <[email protected]>
thisthat
approved these changes
Apr 24, 2023
odubajDT
approved these changes
Apr 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #728