Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reorder integration test execution #1264

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Apr 21, 2023

this pr reorders integration tests so that we can verify that the metrics collector keeps on working after operator restart.

Signed-off-by: realanna <[email protected]>
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 684a18a
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6447b05a69ef3600089eb8ab
😎 Deploy Preview https://deploy-preview-1264--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1264 (529fb51) into main (b3b7010) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   59.76%   59.72%   -0.04%     
==========================================
  Files         138      138              
  Lines       10444    10444              
==========================================
- Hits         6242     6238       -4     
- Misses       3967     3970       +3     
- Partials      235      236       +1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.45% <ø> (-0.86%) ⬇️
lifecycle-operator 78.28% <ø> (ø)
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna marked this pull request as ready for review April 25, 2023 10:51
@RealAnna RealAnna requested a review from a team as a code owner April 25, 2023 10:51
@RealAnna RealAnna changed the title test test: reorder integration test execution Apr 25, 2023
@RealAnna RealAnna changed the title test: reorder integration test execution chore: reorder integration test execution Apr 25, 2023
Signed-off-by: realanna <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RealAnna RealAnna merged commit 71f2f78 into main Apr 25, 2023
@RealAnna RealAnna deleted the test_without_flo's_changes branch April 25, 2023 11:21
@keptn-bot keptn-bot mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants