Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scheduler): Background check for pod status in permit plugin #124

Merged
merged 9 commits into from
Oct 10, 2022
Merged

feat(scheduler): Background check for pod status in permit plugin #124

merged 9 commits into from
Oct 10, 2022

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Oct 6, 2022 •
edited
Loading

Permit plugin should check the waiting queue and reject or approve pods before the eviction

This is for now implemented as a recursive async routine.
A little learning: we cannot queue pod by default, if there is an error due to the pod being evicted etc. the queue action may fail and the scheduler could end up looping indefinitely

@RealAnna RealAnna marked this pull request as ready for review October 7, 2022 11:04
@RealAnna RealAnna changed the title chore: Recursively check for pod status in permit plugin feat: Recursively check for pod status in permit plugin Oct 7, 2022
@thschue thschue changed the title feat: Recursively check for pod status in permit plugin feat(scheduler): Recursively check for pod status in permit plugin Oct 7, 2022
thschue
thschue previously approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

odubajDT
odubajDT previously approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thisthat
thisthat reviewed Oct 10, 2022
View reviewed changes
scheduler/pkg/klcpermit/permit.go Show resolved Hide resolved
scheduler/pkg/klcpermit/permit.go Show resolved Hide resolved
scheduler/pkg/klcpermit/permit.go Show resolved Hide resolved
thschue
thschue approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thisthat thisthat changed the title feat(scheduler): Recursively check for pod status in permit plugin feat(scheduler): Background check for pod status in permit plugin Oct 10, 2022
@thisthat thisthat merged commit 97ceef6 into main Oct 10, 2022
@thisthat thisthat deleted the feat/add_iteration_over_waiting_pods branch October 10, 2022 14:16
@github-actions github-actions bot mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@thschue thschue thschue approved these changes

@thisthat thisthat thisthat approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RealAnna @thisthat @thschue @odubajDT