Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reference pages for Evaluation and Metrics definitions and providers #1224
docs: reference pages for Evaluation and Metrics definitions and providers #1224
Changes from all commits
e089a5d
3246ac6
4c4ef1d
84bc148
9937c95
3350da4
74d49ed
b97cc28
91dac8e
489dcde
4232dd7
f02cb14
76c23bc
d65f789
1f3b8cb
1df95c2
0f1f393
192ea92
4015f51
b8cb8b7
a52a9f7
c0212fb
c5bd13d
610432d
c60874a
e003a8d
771c951
9aea805
ea4146b
e8c5e65
4660b30
53829ce
6ccac15
718dba2
efdd43c
f4266a9
ccb7747
5065023
80deefe
db39067
8664450
326cba2
56cf54d
e500c80
09034be
ba05ab8
b9ec458
7e6bcdc
992903e
6258b62
4828ff4
d431642
2962a04
6153d77
47250d2
502dd9b
d4498ec
143fd29
5db8911
565ce86
e27895b
cb422e2
d9bd066
a2c1ba9
098391e
c12c6cf
f87d60f
fb924ca
8c37067
e6e9a9b
20c4b6c
e35f915
c4d17af
6d1666a
8bef90a
044143c
815df79
937128a
5590c67
72339ab
20a604b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be painful to maintain. At each new API release, we would need to change it. I suggest creating a pointer towards the autogenerated docs of the CRDs to find the right version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feelings about having this manually maintained. The APIs will change continuously and we need to keep this section aligned with the implementation. For the fields, we generate the documentation automatically in the API reference page: https://lifecycle.keptn.sh/docs/crd-ref/
I would rather keep it there so we don't have to maintain the fields in multiple places
This file was deleted.