Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor kuttl test using env var #1214

Merged
merged 8 commits into from
Apr 13, 2023
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Apr 12, 2023

use setenv to substitute $NAMESPACE in keptn metric installation, a generated metric name was added to be able to check the metrics endpoint for a different metric

closes #1181

@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit d33782b
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6436d5f5f9166f0008e4c7f9
😎 Deploy Preview https://deploy-preview-1214--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1214 (b0e0fbf) into main (f9a1bc7) will increase coverage by 0.28%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   58.70%   58.99%   +0.28%     
==========================================
  Files         120      128       +8     
  Lines        9563    10040     +477     
==========================================
+ Hits         5614     5923     +309     
- Misses       3775     3899     +124     
- Partials      174      218      +44     

see 9 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (?)
component-tests 59.71% <ø> (+0.21%) ⬆️
lifecycle-operator 78.24% <ø> (ø)
metrics-operator 77.57% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna force-pushed the test/add_different_check branch from d4e6367 to 44c845c Compare April 12, 2023 15:52
Signed-off-by: realanna <[email protected]>

test: clean version

Signed-off-by: realanna <[email protected]>

test: clean version

Signed-off-by: realanna <[email protected]>

test: rename without -

Signed-off-by: realanna <[email protected]>

test: rename without -

Signed-off-by: realanna <[email protected]>

test: rename job

Signed-off-by: realanna <[email protected]>

test: rename job

Signed-off-by: realanna <[email protected]>

test: refactor kuttl test using env var

Signed-off-by: realanna <[email protected]>

test: refactor kuttl test using env var

Signed-off-by: realanna <[email protected]>

test: refactor kuttl test using env var

Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
@RealAnna RealAnna force-pushed the test/add_different_check branch from 44c845c to d33782b Compare April 12, 2023 16:01
@RealAnna RealAnna force-pushed the test/add_different_check branch from d84f3ed to af8772f Compare April 12, 2023 16:18
@RealAnna RealAnna marked this pull request as ready for review April 12, 2023 16:35
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 24b2674 into main Apr 13, 2023
@RealAnna RealAnna deleted the test/add_different_check branch April 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose-keptn-metric integration test only works once
3 participants