Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: modify footer #1163

Merged
merged 4 commits into from
Apr 26, 2023
Merged

docs: modify footer #1163

merged 4 commits into from
Apr 26, 2023

Conversation

rakshitgondwal
Copy link
Member

Fixes #1136

Modified the footer of the website with the following changes:

  • In the Keptn Recordings part, added a new button that redirects to Youtube.
  • Renamed the Read more.... to Github in the contributions welcome part.
  • Renaming the Read more... to Twitter in the Follow us on Twitter part.
  • Added a new assets/scss/_variable_project.scss file for the custom modification of the styles.

Screenshots

New

Screenshot from 2023-03-31 15-14-05

Old

Screenshot from 2023-03-31 15-14-10

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 31, 2023
@netlify
Copy link

netlify bot commented Mar 31, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 961d2d3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6448d337ed823f0008600d4c
😎 Deploy Preview https://deploy-preview-1163--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rakshitgondwal
Copy link
Member Author

@aepfli @agardnerIT Please have a look.

agardnerIT
agardnerIT previously approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aepfli
Copy link
Member

aepfli commented Apr 3, 2023

LGTM, but a little nitpicking. Buttons are a call to action and Twitter is not an action, Follow us would be one. eg
image

  • This gives clear Call-To-Actions to the user.

But overall it looks good to me :)

aepfli
aepfli previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint will complain, about inline HTML. My suggestions should fix this.

Background

we try to avoid HTML within our markdown files as much as possible. This is the start page, and therefore might contain HTML to better visualize the entrypoint into our documentation.

docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Show resolved Hide resolved
aepfli
aepfli previously approved these changes Apr 3, 2023
View reviewed changes
@rakshitgondwal rakshitgondwal mentioned this pull request Apr 15, 2023
Closed
7 tasks
@rakshitgondwal
Copy link
Member Author

Fixed merge conflicts!
Kindly re-review @aepfli @StackScribe @agardnerIT.

@rakshitgondwal @thisthat
docs: modify footer
f17a741 
Signed-off-by: Rakshit Gondwal <[email protected]>
@rakshitgondwal @thisthat
docs: modify buttons and add bg color
8332d19 
Signed-off-by: Rakshit Gondwal <[email protected]>
@rakshitgondwal @thisthat
docs: fix markdownlint errors
d1012d1 
Signed-off-by: Rakshit Gondwal <[email protected]>
@rakshitgondwal @thisthat
docs: fix markdownlint errors
961d2d3 
Signed-off-by: Rakshit Gondwal <[email protected]>
@thisthat thisthat requested review from a team as code owners April 26, 2023 07:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

thisthat
thisthat approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisthat thisthat merged commit ee4ffcf into keptn:main Apr 26, 2023
@keptn-bot keptn-bot mentioned this pull request Apr 26, 2023
Merged
@rakshitgondwal
Copy link
Member Author

Thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepfli aepfli aepfli approved these changes

@thisthat thisthat thisthat approved these changes

@thschue thschue Awaiting requested review from thschue

@bacherfl bacherfl Awaiting requested review from bacherfl

@StackScribe StackScribe Awaiting requested review from StackScribe

@agardnerIT agardnerIT Awaiting requested review from agardnerIT

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify the footer of KLT website.
4 participants
@rakshitgondwal @aepfli @thisthat @agardnerIT