-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [PoC] Draft of YAML oriented CRD ref page that is autogenerated (rejected) #1070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
StackScribe
requested review from
thisthat,
thschue and
bacherfl
as code owners
March 20, 2023 02:20
github-actions
bot
added
documentation
Improvements or additions to documentation
operator
labels
Mar 20, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
StackScribe
added
the
status: ready-for-refinement
Issue is relevant for the next backlog refinment
label
Mar 20, 2023
We discussed this at the 22 March [Keptn Refinement Meeting]. Conclusions were:
Recommended actions:
|
StackScribe
changed the title
docs: [PoC] Draft of KeptnTaskDefinitionList CRD ref page
docs: [PoC] Draft of YAML oriented CRD ref page that is autogenerated (rejected)
Mar 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
status: ready-for-refinement
Issue is relevant for the next backlog refinment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS EVER!!! IT INCLUDES pseudo-ish code that does not build.
This is based on the following existing documentation:
We want auto-generated reference pages but we need additional content to make them interesting and useful to users. This requires adding authored content to the autogenerated content. The user sees a CRD mostly as the yaml file they must create. The authored content should be co-located with the source code to make it easy for developers to identify when source code changes necessitate doc modifications.
This is a mock-up of the structure and content I propose. I think it gives the user the information they need and a format that allows us to easily add information as we see what information users need. This augments the current auto-generated pages as follows:
adding this amount of content for all CRDs in the existing library file would make for an unwieldy file.
Some tools work is required to support this amount of markdown formatting in a go file. That is a separate discussion and it is possible that we will find out that it is not possible to implement this design. But the purpose of this exercise is to agree about what we want.