Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatically set the start date for issues in GitHub projects #1033

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

rakshitgondwal
Copy link
Member

Fixes #1011

This pipeline would automatically set the Start Date field in the KLT project to the current date, whenever an issue is assigned.

Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 7a0ab03
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/640f3da6dbe1dd0008c28e43
😎 Deploy Preview https://deploy-preview-1033--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thisthat
thisthat previously approved these changes Mar 13, 2023
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rakshitgondwal LGTM ✅

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1033 (bc3cab3) into main (92d16a3) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   58.61%   58.67%   +0.06%     
==========================================
  Files         124      124              
  Lines        9910     9910              
==========================================
+ Hits         5809     5815       +6     
+ Misses       3886     3881       -5     
+ Partials      215      214       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.04% <ø> (+0.65%) ⬆️
lifecycle-operator 78.39% <ø> (ø)
metrics-operator 77.00% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but what do you think about merging the 2 pipeline files into one and having all steps in one file with a few ifs around things?

@rakshitgondwal
Copy link
Member Author

LGTM overall, but what do you think about merging the 2 pipeline files into one and having all steps in one file with a few ifs around things?

I was thinking about this too! This totally depends on the complexity and the similarity of the two tasks and I think that both the tasks (setting the end date and start date) are pretty similar, we'll just have to put an if condition checking the event and action that triggered the pipeline.

@mowies
Copy link
Member

mowies commented Mar 13, 2023

@rakshitgondwal ok awesome, so if you agree, then let's put the 2 files into one :)

@mowies mowies changed the title ci: automatically set the start date in GitHub projects ci: automatically set the start date for issues in GitHub projects Mar 14, 2023
.github/workflows/set-date.yml Outdated Show resolved Hide resolved
.github/workflows/set-date.yml Outdated Show resolved Hide resolved
.github/workflows/set-date.yml Outdated Show resolved Hide resolved
.github/workflows/set-date.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ops label Mar 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff @rakshitgondwal!

@mowies mowies merged commit 2a66ea0 into keptn:main Mar 15, 2023
@rakshitgondwal
Copy link
Member Author

Thanks a lot for the merge!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline to add automation to GitHub project :: Set start date when issue assigned
3 participants