-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automatically set the start date for issues in GitHub projects #1033
Conversation
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rakshitgondwal LGTM ✅
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
+ Coverage 58.61% 58.67% +0.06%
==========================================
Files 124 124
Lines 9910 9910
==========================================
+ Hits 5809 5815 +6
+ Misses 3886 3881 -5
+ Partials 215 214 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but what do you think about merging the 2 pipeline files into one and having all steps in one file with a few if
s around things?
I was thinking about this too! This totally depends on the complexity and the similarity of the two tasks and I think that both the tasks (setting the end date and start date) are pretty similar, we'll just have to put an |
@rakshitgondwal ok awesome, so if you agree, then let's put the 2 files into one :) |
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great stuff @rakshitgondwal!
Thanks a lot for the merge!! |
Fixes #1011
This pipeline would automatically set the
Start Date
field in the KLT project to the current date, whenever an issue is assigned.