Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add KLT components diagram #1016

Merged
merged 3 commits into from
Mar 15, 2023
Merged

docs: add KLT components diagram #1016

merged 3 commits into from
Mar 15, 2023

Conversation

Amishakumari544
Copy link
Contributor

Fixes #1014

@netlify
Copy link

netlify bot commented Mar 9, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c0b884e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64102c64a2ae890008473cd9
😎 Deploy Preview https://deploy-preview-1016--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Amishakumari544 Amishakumari544 marked this pull request as draft March 9, 2023 11:05
@Amishakumari544 Amishakumari544 marked this pull request as ready for review March 9, 2023 11:20
StackScribe
StackScribe reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice -- I like it! A couple suggestions...

Did you use commit -s for this PR? It is failing DCO but my PRs are failing DCO even though I used commit -s. So let me know if this is another instance of that.

@Amishakumari544
Copy link
Contributor Author

Very nice -- I like it! A couple suggestions...

Did you use commit -s for this PR? It is failing DCO but my PRs are failing DCO even though I used commit -s. So let me know if this is another instance of that.

Yup,I used multiple times but don't know why it's failing the dco will check again.

@aepfli
Copy link
Member

aepfli commented Mar 9, 2023

i am the reason for the failing DCO i am sorry - i used the Browser IDE and i forget that it does not sign automatically :(

@Amishakumari544
Copy link
Contributor Author

i am the reason for the failing DCO i am sorry - i used the Browser IDE and i forget that it does not sign automatically :(

no issues @aepfli :)

@Amishakumari544
Copy link
Contributor Author

@aepfli DCO is not working.If you can check.

@aepfli aepfli added the documentation Improvements or additions to documentation label Mar 9, 2023
StackScribe
StackScribe reviewed Mar 13, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! I nit-picked at your prose to tighten it up a bit but I definitely like this!

@Amishakumari544
fix markdownlint
b179c6a 
Signed-off-by: Amishakumari544 <[email protected]>
@Amishakumari544
add new linktitle
c0b884e 
Signed-off-by: Amishakumari544 <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aepfli
aepfli approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you very much

@StackScribe StackScribe merged commit dcf49cf into keptn:main Mar 15, 2023
This was referenced Mar 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepfli aepfli aepfli approved these changes

@StackScribe StackScribe StackScribe approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@thschue thschue Awaiting requested review from thschue

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keptn Lifecycle Toolkit Component Diagram
3 participants
@Amishakumari544 @aepfli @StackScribe