Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add example release logic #1008

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Mar 8, 2023

No description provided.

Signed-off-by: Simon Schrottner <[email protected]>
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 33a5acf
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/641c102d18eb210007832e14
😎 Deploy Preview https://deploy-preview-1008--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1008 (f6a9402) into main (8608f11) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head f6a9402 differs from pull request most recent head 65d221d. Consider uploading reports for the commit 65d221d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
+ Coverage   58.91%   58.98%   +0.06%     
==========================================
  Files         126      126              
  Lines       10007    10007              
==========================================
+ Hits         5896     5903       +7     
+ Misses       3893     3888       -5     
+ Partials      218      216       -2     

see 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.47% <ø> (-0.58%) ⬇️
lifecycle-operator 78.40% <ø> (ø)
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aepfli aepfli added the documentation Improvements or additions to documentation label Mar 8, 2023
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what this pipeline is doing. Right now, from what I understand, it would copy the examples folder content from keptn/lifecycle-toolkit into ./tmp/examples in the keptn-sandbox/lifecycle-toolkit-examples repo and push that.
What's the reasoning behind that?

.github/workflows/release-examples.yml Outdated Show resolved Hide resolved
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli
Copy link
Member Author

aepfli commented Mar 9, 2023

I don't really understand what this pipeline is doing. Right now, from what I understand, it would copy the examples folder content from keptn/lifecycle-toolkit into ./tmp/examples in the keptn-sandbox/lifecycle-toolkit-examples repo and push that. What's the reasoning behind that?

the tmp/examples folder is a git checkout of the lifecycle-toolkit-examples, so we do push those into the root. We do have two checkouts in this pipeline :)

the problem is https://github.com/keptn/lifecycle-toolkit/blob/v0.6.0/.github/actions/update-documentation/scripts/update_docs.py#L52

this line was part of the old documentation release and ensured that the most reason example files are within the example repo.
With this pull request, we add the functionality back in here - but in a way, that is not hidden in another process - more visible.

As far as I am informed, we want to have the most recent examples ready to fork for people to play with.

mowies
mowies previously approved these changes Mar 9, 2023
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @aepfli !
I misunderstood the code apparently 😅

@mowies mowies changed the title fix: add example release logic ci: add example release logic Mar 9, 2023
@github-actions github-actions bot added ops and removed documentation Improvements or additions to documentation labels Mar 23, 2023
thisthat
thisthat previously approved these changes Mar 23, 2023
thisthat
thisthat previously approved these changes Mar 23, 2023
.github/workflows/release-examples.yml Outdated Show resolved Hide resolved
.github/workflows/release-examples.yml Outdated Show resolved Hide resolved
.github/workflows/release-examples.yml Outdated Show resolved Hide resolved
.github/workflows/release-examples.yml Outdated Show resolved Hide resolved
.github/workflows/release-examples.yml Outdated Show resolved Hide resolved
@mowies
Copy link
Member

mowies commented Mar 23, 2023

@aepfli i left some more comments. also, did you test the release pipeline in your fork? If not, please do so to show that the whole setup still works.

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli
Copy link
Member Author

aepfli commented Mar 23, 2023

@aepfli i left some more comments. also, did you test the release pipeline in your fork? If not, please do so to show that the whole setup still works.

i tested it, and it sadly works :( https://github.com/keptn-sandbox/lifecycle-toolkit-examples - used my token but it seems like i have more permissions in the keptn-sandbox. - https://github.com/aepfli/lifecycle-toolkit/actions/runs/4500288808/jobs/7919264663

@mowies
Copy link
Member

mowies commented Mar 23, 2023

should i revert the release in the examples repo? i think it's fine anyways since we needed it for KLT 0.7.0

@aepfli
Copy link
Member Author

aepfli commented Mar 23, 2023

should i revert the release in the examples repo? i think it's fine anyways since we needed it for KLT 0.7.0

i took a look, and i think it is fine, i will delete the tag - we would have needed to commit this anyways :)

@aepfli
Copy link
Member Author

aepfli commented Mar 23, 2023

with peribolos we also want to migrate this repository to the keptn org i think

@mowies
Copy link
Member

mowies commented Mar 23, 2023

ok. then you just need to signoff your last commit and this should be ready to merge

@aepfli
Copy link
Member Author

aepfli commented Mar 23, 2023

i hate github.dev - it is cool an easy to do things in the browser, but not signing something automatically is really annoying :D

Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli force-pushed the fix/releasing_of_examples branch from f6a9402 to 65d221d Compare March 23, 2023 12:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mowies mowies merged commit 3c96a02 into keptn:main Mar 23, 2023
aepfli added a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants