-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add example release logic #1008
Conversation
Signed-off-by: Simon Schrottner <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
+ Coverage 58.91% 58.98% +0.06%
==========================================
Files 126 126
Lines 10007 10007
==========================================
+ Hits 5896 5903 +7
+ Misses 3893 3888 -5
+ Partials 218 216 -2 see 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what this pipeline is doing. Right now, from what I understand, it would copy the examples
folder content from keptn/lifecycle-toolkit
into ./tmp/examples
in the keptn-sandbox/lifecycle-toolkit-examples
repo and push that.
What's the reasoning behind that?
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
the the problem is https://github.com/keptn/lifecycle-toolkit/blob/v0.6.0/.github/actions/update-documentation/scripts/update_docs.py#L52 this line was part of the old documentation release and ensured that the most reason example files are within the example repo. As far as I am informed, we want to have the most recent examples ready to fork for people to play with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @aepfli !
I misunderstood the code apparently 😅
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli i left some more comments. also, did you test the release pipeline in your fork? If not, please do so to show that the whole setup still works. |
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
i tested it, and it sadly works :( https://github.com/keptn-sandbox/lifecycle-toolkit-examples - used my token but it seems like i have more permissions in the keptn-sandbox. - https://github.com/aepfli/lifecycle-toolkit/actions/runs/4500288808/jobs/7919264663 |
should i revert the release in the examples repo? i think it's fine anyways since we needed it for KLT 0.7.0 |
i took a look, and i think it is fine, i will delete the tag - we would have needed to commit this anyways :) |
with peribolos we also want to migrate this repository to the keptn org i think |
ok. then you just need to signoff your last commit and this should be ready to merge |
i hate github.dev - it is cool an easy to do things in the browser, but not signing something automatically is really annoying :D |
Signed-off-by: Simon Schrottner <[email protected]>
f6a9402
to
65d221d
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Moritz Wiesinger <[email protected]>
No description provided.