Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): rework Workload and Application span structure #452

Merged
merged 12 commits into from
Nov 24, 2022

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Nov 22, 2022

Closes #409 #410

Screenshot 2022-11-22 at 13 44 08

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #452 (9000d2d) into main (29fa0e5) will increase coverage by 0.48%.
The diff coverage is 61.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #452      +/-   ##
==========================================
+ Coverage   43.28%   43.77%   +0.48%     
==========================================
  Files          27       27              
  Lines        2116     2136      +20     
==========================================
+ Hits          916      935      +19     
+ Misses       1118     1115       -3     
- Partials       82       86       +4     
Impacted Files Coverage Δ
...or/controllers/keptnworkloadinstance/controller.go 51.03% <42.30%> (+1.56%) ⬆️
operator/controllers/keptnappversion/controller.go 72.30% <45.45%> (+0.43%) ⬆️
operator/controllers/common/phaseitem.go 95.31% <100.00%> (+0.15%) ⬆️
operator/controllers/common/spanhandler.go 83.33% <100.00%> (+4.76%) ⬆️
operator/controllers/keptnapp/controller.go 65.88% <100.00%> (ø)
Flag Coverage Δ
keptn-lifecycle-operator 48.30% <61.81%> (+0.49%) ⬆️
scheduler 4.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the feat/409/application-span branch from de7b0a0 to 8c1dee7 Compare November 22, 2022 10:24
@odubajDT odubajDT changed the title feat(operator): reorganise spans feat(operator): rework Workload and Application span structure Nov 22, 2022
@odubajDT odubajDT marked this pull request as ready for review November 22, 2022 14:49
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the initial issue, the tasks and evaluations themselves should also be visible in the trace, which is missing in the current screenshot.

odubajDT
odubajDT previously approved these changes Nov 22, 2022
@odubajDT
Copy link
Contributor

According to the initial issue, the tasks and evaluations themselves should also be visible in the trace, which is missing in the current screenshot.

Task and evaluation spans restructuring will be handled in a separate PR, this PR restructures only workload and app spans, see the linked issues

@odubajDT odubajDT requested a review from thschue November 22, 2022 14:56
@bacherfl
Copy link
Member Author

According to the initial issue, the tasks and evaluations themselves should also be visible in the trace, which is missing in the current screenshot.

There is a separate issue for that: #411

odubajDT
odubajDT previously approved these changes Nov 23, 2022
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

@odubajDT odubajDT requested a review from thisthat November 24, 2022 09:30
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good work!

@thschue thschue merged commit 9a483ce into keptn:main Nov 24, 2022
@keptn-bot keptn-bot mentioned this pull request Nov 24, 2022
@bacherfl bacherfl deleted the feat/409/application-span branch November 24, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework Application Span structure
4 participants