-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): use correct parent/child span relationship #418
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 32.84% 37.99% +5.14%
==========================================
Files 19 28 +9
Lines 1516 2082 +566
==========================================
+ Hits 498 791 +293
- Misses 989 1227 +238
- Partials 29 64 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
I guess we might want to fix this in workloadInstance as well https://github.com/keptn/lifecycle-toolkit/blob/main/operator/controllers/keptnworkloadinstance/controller.go#L162 |
At the moment, this is not problematic since the parent/child relationship for Workload is correct. However, this will be reworked with #410 |
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
9a87943
to
8b7eeaa
Compare
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Giovanni Liva [email protected]
Fixes #336