Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing: Incorrect parent/child relationship #336

Closed
1 task
Tracked by #388
thisthat opened this issue Nov 8, 2022 · 0 comments · Fixed by #418
Closed
1 task
Tracked by #388

Tracing: Incorrect parent/child relationship #336

thisthat opened this issue Nov 8, 2022 · 0 comments · Fixed by #418
Assignees
@thisthat
Labels
bug Something isn't working
Milestone
0.4.1

Comments

@thisthat
Copy link
Member

thisthat commented Nov 8, 2022

Problem

image

In the picture it is visible the problem. The Span for AppPreDeployTask is parent of AppPreDeployEvaluation. Instead, they should be siblings.
The problem is that the wrong ctx is used to create the AppPreDeployEvaluation Span.

DoD

  • AppPreDeployEvaluation and AppPreDeployTask are siblings' Spans
@thisthat thisthat added the bug Something isn't working label Nov 8, 2022
@thschue thschue added this to the 0.5.x milestone Nov 9, 2022
@thisthat thisthat moved this to 🎟️ Refined in Keptn Lifecycle Toolkit Nov 14, 2022
@thisthat thisthat modified the milestones: 0.5.x, 0.4.1 Nov 14, 2022
@thisthat thisthat self-assigned this Nov 15, 2022
@thisthat thisthat mentioned this issue Nov 15, 2022
Merged
@thisthat thisthat moved this from 🎟️ Refined to 🏃 In progress in Keptn Lifecycle Toolkit Nov 16, 2022
thschue pushed a commit that referenced this issue Nov 21, 2022
@thisthat
fix(operator): use correct parent/child span relationship (#418)
24efc80 
Co-authored-by: RealAnna <[email protected]>
Fixes #336
Repository owner moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisthat thisthat

Labels
bug Something isn't working
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

fix(operator): use correct parent/child span relationship thisthat/lifecycle-controller
2 participants
@thisthat @thschue