Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Keptn Annotations #4

Closed
4 tasks
Tracked by #8 ...
thisthat opened this issue Sep 2, 2022 · 1 comment
Closed
4 tasks
Tracked by #8 ...

Bootstrap Keptn Annotations #4

thisthat opened this issue Sep 2, 2022 · 1 comment

Comments

@thisthat
Copy link
Member

thisthat commented Sep 2, 2022

Goal

Define the set of annotations on which the Webhook Admission Controller reacts, their format, their default value, and their name.

Technical Details

The Mutating Webhook should only change manifests that are annotated with Keptn special annotations.
Keptn should track the following properties:

  • instance
  • application
  • (micro)service / component
  • version

Draft proposal of annotations with example values:

keptn.sh/instance: eu-central
keptn.sh/application: my-super-cool-application
keptn.sh/component: microservice-1
keptn.sh/version: "1.0"

Not all of these annotations are mandatory for Keptn to track the lifecycle. Hence, the goal of this research is to define the mandatory annotations and the default values for the missing ones.

Acceptance Criteria

  • Decide the list of mandatory annotations
  • Decide default values for missing annotations
  • Define the format and names

DoD

  • Document the results in the README file
@odubajDT
Copy link
Contributor

odubajDT commented Sep 14, 2022

According to the discussion with the team, we came to a conclusion that the keptn.sh/application and keptn.sh/component annotations will be for now mandatory. Others will be optional, as it is practically impossible to decide in the current state what annotation will the system use and what default values will they have. We can easily add them when any of them will be needed

@thisthat thisthat closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants