Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Controller should monitor job failure #380

Closed
Tracked by #398
RealAnna opened this issue Nov 10, 2022 · 0 comments · Fixed by #424
Closed
Tracked by #398

Task Controller should monitor job failure #380

RealAnna opened this issue Nov 10, 2022 · 0 comments · Fixed by #424
Assignees
@bacherfl
Labels
bug Something isn't working
Milestone
0.4.1

Comments

@RealAnna
Copy link
Contributor

The task controller right now lets the job enter a crash state, this makes the whole deployment to be stuck in pending state. The controller should have a retry logic and an explicit failure.
@RealAnna RealAnna added the bug Something isn't working label Nov 10, 2022
@RealAnna RealAnna added this to the 0.5.x milestone Nov 10, 2022
@thschue thschue modified the milestones: 0.5.x, 0.4.1 Nov 11, 2022
@thisthat thisthat moved this to 🎟️ Refined in Keptn Lifecycle Toolkit Nov 14, 2022
@bacherfl bacherfl self-assigned this Nov 16, 2022
@bacherfl bacherfl moved this from 🎟️ Refined to 🏃 In progress in Keptn Lifecycle Toolkit Nov 16, 2022
@bacherfl bacherfl mentioned this issue Nov 16, 2022
Merged
thschue pushed a commit that referenced this issue Nov 21, 2022
@bacherfl
fix(operator): detect Job failure and set Task to failed (#424)
19114db 
Closes #380
Repository owner moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bacherfl bacherfl

Labels
bug Something isn't working
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

fix(operator): detect Job failure and set Task to failed bacherfl/lifecycle-controller
3 participants
@bacherfl @thschue @RealAnna