fix(lifecycle-operator): close root spans of failed AppVersions/WorkloadVersions #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kloadVersions Signed-off-by: Florian Bacher <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3174 +/- ##
==========================================
- Coverage 86.85% 86.82% -0.04%
==========================================
Files 162 162
Lines 8605 8629 +24
==========================================
+ Hits 7474 7492 +18
- Misses 841 844 +3
- Partials 290 293 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
changed the title
Signed-off-by: Florian Bacher <[email protected]>
|
odubajDT
approved these changes
Mar 4, 2024
mowies
approved these changes
Mar 4, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
…oadVersions (keptn#3174) Signed-off-by: Florian Bacher <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3130
This PR ensures the root spans of a KeptnAppVersion or KeptnWorkloadVersion are closed when one of their sub-phases fails, as seen in the following examples:
Failed KeptnAppVersion pre deployment task
Failed KeptnWorkloadVersion pre deployment task - error is propagated up to KeptnAppVersion:
